New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation #568

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
2 participants
@miyahan
Contributor

miyahan commented Nov 4, 2017

for #509 馃崳

@squidfunk squidfunk merged commit 63ebc68 into squidfunk:master Nov 5, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@squidfunk

This comment has been minimized.

Owner

squidfunk commented Nov 5, 2017

Thanks! I renamed the file to ja.html, because that's what the language code says, and strangely what the HTML5 docs say.

@miyahan

This comment has been minimized.

Contributor

miyahan commented Nov 5, 2017

Thanks!

I think so, too. However, When rename jp.html to ja.html, I can not search Japanese (non-ASCII characters). Because, It requires lunr-languages, but lunr.ja.js does not exist in 1.0.0 release. Instead lunr.jp.js exists.

In the master branch, it was renamed to lunr.ja.js, and lunr.jp.js became an alias to it.
(ref: Change Japanese language code, jp into ja by fmy 路 Pull Request #33 路 MihaiValentin/lunr-languages)

So, MkDocs Material must load lunr.jp.js when language set to ja until next release of lunr-languages...

@squidfunk

This comment has been minimized.

Owner

squidfunk commented Nov 5, 2017

I see the problem. For this reason theme language and search languages were separated again in 2.x. Please upgrade to 2.x and set the following:

theme:
  language: ja

extra:
  search:
    language: jp
@miyahan

This comment has been minimized.

Contributor

miyahan commented Nov 5, 2017

I read the document and set it as extra/search/languages = jp. I fixed it to extra/search/language = jp and I now can search Japanese. Thanks !!

@squidfunk

This comment has been minimized.

Owner

squidfunk commented Nov 5, 2017

No problem, it was an error in the documentation which I fixed a few minutes ago.

@miyahan miyahan deleted the miyahan:japanese branch Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment