Add Support for Q.VOLT HYB-G3-3P #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimKraus
force-pushed
the
feature/QVOLTHYBG33P-Inverter
branch
from
761d231
to
6e7c8e6
Compare
|
I think it makes sense to add it to the library. We might want to split it out into a separate discovery mechanism though, so that home-assistant users don't get confused. For now we can just add it here and cross that bridge when they do get confused :) |
VadimKraus
force-pushed
the
feature/QVOLTHYBG33P-Inverter
branch
from
4f4c43d
to
bd044be
Compare
squishykid
requested changes
Feb 21, 2022
solax/utils.py
Outdated
| @@ -1,3 +1,25 @@ | |||
| INVERTER_OPERATION_MODES = { | |||
There was a problem hiding this comment.
My only comment would be: Could you please move these added constants and functions inside the QVOLTHYBG33P class? The new class is the only class which currently uses these values.
|
Should just be a small change and then it's ready to merge! |
|
Nice work! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Q.VOLT HYB-G3-3P" is part of the "Q.HOME+ ESS HYB-G3-3P" Set, which is a clone/relabel of X ESS G4 and contains a "X3 Hybrid G4".
Since I only have access to the QCells variante, this PR adds an inverter with the name "QVOLTHYBG33P".
The mapping was done by best effort, however, there are still some data points in the repose which I could not identify.