From 79d5fdff2c017747288b8a50c9e7d7761362543c Mon Sep 17 00:00:00 2001 From: Greg Sherwood Date: Tue, 24 Apr 2018 08:38:56 +1000 Subject: [PATCH] Using isset() for performance (ref #2003) --- .../Operators/ComparisonOperatorUsageSniff.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php b/src/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php index 4fc87ba862..ac16250bd9 100644 --- a/src/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php +++ b/src/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php @@ -32,13 +32,13 @@ class ComparisonOperatorUsageSniff implements Sniff * @var array */ private static $validOps = [ - T_IS_IDENTICAL, - T_IS_NOT_IDENTICAL, - T_LESS_THAN, - T_GREATER_THAN, - T_IS_GREATER_OR_EQUAL, - T_IS_SMALLER_OR_EQUAL, - T_INSTANCEOF, + T_IS_IDENTICAL => true, + T_IS_NOT_IDENTICAL => true, + T_LESS_THAN => true, + T_GREATER_THAN => true, + T_IS_GREATER_OR_EQUAL => true, + T_IS_SMALLER_OR_EQUAL => true, + T_INSTANCEOF => true, ]; /** @@ -157,7 +157,7 @@ public function process(File $phpcsFile, $stackPtr) for ($i = $start; $i <= $end; $i++) { $type = $tokens[$i]['code']; - if (in_array($type, array_keys(self::$invalidOps[$tokenizer])) === true) { + if (isset(self::$invalidOps[$tokenizer][$type]) === true) { $error = 'Operator %s prohibited; use %s instead'; $data = [ $tokens[$i]['content'], @@ -165,7 +165,7 @@ public function process(File $phpcsFile, $stackPtr) ]; $phpcsFile->addError($error, $i, 'NotAllowed', $data); $foundOps++; - } else if (in_array($type, self::$validOps) === true) { + } else if (isset(self::$validOps[$type]) === true) { $foundOps++; }