Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide LICENSE #273

Closed
remicollet opened this issue Oct 9, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@remicollet
Copy link

commented Oct 9, 2014

The LICENSE file is availa in the repo,
Please add it to the package.xml so it will part of next official archive available from PEAR.

@aik099

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2014

While we're at it the file itself needs to be renamed from license.txt to LICENSE according to open source project rules.

@remicollet

This comment has been minimized.

Copy link
Author

commented Oct 9, 2014

It could also make sense to add README and CONTRIBUTING with role="doc".
LICENSE is mandatory for downstream... per license term...

* Redistributions of source code must retain the above copyright ...
@gsherwood

This comment has been minimized.

Copy link
Member

commented Oct 10, 2014

Having the licence file distributed in PEAR places it in a completely different directory away from the actual source code, so it's basically useless. That's why the package.xml and every file header points to the licence file on Github.

Changing the name would require me to change every file header, and instantly break links in the header of all existing distributions, so I'm not going to do that. Also, there is absolutely no requirement to name the licence file LICENCE. The licence file can be named anything you want (especially given there are 2 spellings). All naming and availability is provided for convenience.

Just to clarify: I am not currently in breach of my own licence just because the file is called licence.txt and it is not in the package.xml file.

Having said all that, I'll add the licence.txt entry into the package.xml file considering you've asked for it. I just want to be clear that this change does not affect the licensing of PHP_CodeSniffer in any way.

gsherwood added a commit that referenced this issue Oct 10, 2014

@gsherwood

This comment has been minimized.

Copy link
Member

commented Oct 10, 2014

I've committed the change here: b7f98a3

I added the README and CONTRIBUTING files and even changed them names on install for you @aik099 :)

@gsherwood gsherwood closed this Oct 10, 2014

martinssipenko pushed a commit to discovery-digital/PHP_CodeSniffer that referenced this issue Oct 20, 2014

Martins Sipenko
Merge remote-tracking branch 'source/phpcs-fixer' into phpcs-fixer
* source/phpcs-fixer: (112 commits)
  Fixer now uses temporary system files for diffing rather than creating them in the current working dir
  Prepare for 2.0.0RC3 release
  Sniff doesnt do indent checks + fixed the .fixed file name
  Added new test for fixable error
  Fixed a problem with one of the fixes, and testing for more things
  Set timezone during unit test run
  Coding standards fix
  Added fixes for more class errors
  PHPUnit is testing a file, not a dir
  Coding standards fix
  Removed error Squiz.Classes.ClassDeclaration.NoNewlineAfterCloseBrace (request squizlabs#285)
  Squiz ClassDeclarationSniff now has better checking for blank lines after a closing brace
  Same check as the SpaceIndentSniff so metrics are correct
  Fixed bug squizlabs#280 : The --config-show option generates error when there is no config file
  Skip .fixed files in 1.5.x versions as well (request squizlabs#288)
  Removing unused "$type" variable and long line split into two
  Switch from nesting conditional to continue
  Fix DisallowSpaceIndent to allow top-level PHP DocBlocks
  Squiz FileCommentSniff no longer throws incorrect blank line before comment errors in JS files
  Added readme, contrib and licence files to PEAR distribution (request squizlabs#273)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.