Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens: Add new $ooScopeTokens property. #1415

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 8, 2017

Add new $ooScopeTokens property representing all tokens which typically open class-like constructs.

This is particularly useful if a sniff needs to behave differently when it encounters a token within one of those scopes, like in the case of NamingConvention sniffs.

Applied the use of the property in a few places in existing sniffs.

@jrfnl jrfnl force-pushed the feature/add-ooscopetokens-property branch 3 times, most recently from 2588cde to 3005a9d Compare May 4, 2017 02:54
@jrfnl
Copy link
Contributor Author

jrfnl commented May 4, 2017

Rebased for merge conflicts / v3.0 release.

@jrfnl jrfnl force-pushed the feature/add-ooscopetokens-property branch from 3005a9d to 48e3028 Compare May 4, 2017 03:03
@gsherwood gsherwood added this to the 3.1.0 milestone Jun 13, 2017
Add new `$ooScopeTokens` property representing all tokens which typically open class-like constructs.

This is particularly useful if a sniff needs to behave differently when it encounters a token within one of those scopes, like in the case of NamingConvention sniffs.

Applied the use of the property in a few places in existing sniffs.
@jrfnl jrfnl force-pushed the feature/add-ooscopetokens-property branch from 48e3028 to 93131eb Compare July 24, 2017 17:05
@gsherwood gsherwood merged commit 93131eb into squizlabs:master Aug 6, 2017
gsherwood added a commit that referenced this pull request Aug 6, 2017
@gsherwood
Copy link
Member

Works nicely. Thanks.

@jrfnl jrfnl deleted the feature/add-ooscopetokens-property branch August 6, 2017 23:30
@jrfnl
Copy link
Contributor Author

jrfnl commented Aug 6, 2017

You're welcome Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants