Fixed: Bug #20029, ForbiddenFunction sniff now ignores method renames #143

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mythril
mythril commented Aug 5, 2013

and visibility changes from use clauses.

Reported Here

@gsherwood
Member

I tried just checking for ignored tokens after (as well as before) and it seemed to work fine. Also supports insteadof then as well.

Commit is here: 7c7493b

Let me know if that works for you as well.

@mythril
mythril commented Aug 7, 2013

So this addresses #141 and #143? (in reference to 7c7493b)

Tested it on my target codebase and it seems to do the trick for both.

@mythril mythril closed this Aug 7, 2013
@gsherwood
Member

Thanks a lot for testing. I was in such a rush yesterday that I didn't even notice the other PR (just saw extra errors during testing) and didn't even say thanks.

So yes, they can both remain closed now, and thanks a lot for providing me with the code to replicate these problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment