Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gitmodified filter will infinitely loop when encountering deleted file paths #2393

Merged
merged 1 commit into from Jan 30, 2019

Conversation

3 participants
@lmanzke
Copy link
Contributor

commented Jan 29, 2019

Deleted files cause realpath($path) to return false. When this value
enters the while loop, it will run indefinitely as the condition will
never be matched.

Skip deleted files when filtering for git-modified
Deleted files cause realpath($path) to return false. When this value
enters the while loop, it will run indefinitely as the condition will
never be matched.
@jrfnl

jrfnl approved these changes Jan 29, 2019

Copy link
Contributor

left a comment

Makes sense to me.

@gsherwood gsherwood added this to Backlog in PHPCS v3 Development via automation Jan 30, 2019

@gsherwood gsherwood added this to the 3.4.1 milestone Jan 30, 2019

@gsherwood gsherwood changed the title Skip deleted files when filtering for git-modified The gitmodified filter will infinitely loop when encountering deleted file paths Jan 30, 2019

@gsherwood gsherwood merged commit c112065 into squizlabs:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

PHPCS v3 Development automation moved this from Backlog to Ready for Release Jan 30, 2019

gsherwood added a commit that referenced this pull request Jan 30, 2019

@gsherwood

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Thanks a lot for finding and fixing this.

@gsherwood gsherwood added the Bug label Jan 30, 2019

@lmanzke

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

You're welcome :)

@lmanzke lmanzke deleted the lmanzke:bugfix/infinite-modified-loop branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.