Skip to content

[BUGFIX] #19655 - Commas in closure definitions were improperly parsed #64

Closed
wants to merge 2 commits into from

2 participants

@triplepoint

I added a test for PEAR_Sniffs_Functions_FunctionDeclarationSniff to cover
undesirable behavior for closure definitions with multiple parameters on
a single line. See bug definition for details.

I also added a fix in PEAR_Sniffs_Functions_FunctionDeclarationSniff for this
condition.

triplepoint added some commits Oct 22, 2012
@triplepoint triplepoint repair for Bug #19655
Added a test for PEAR_Sniffs_Functions_FunctionDeclarationSniff to cover
undesirable behavior for closure definitions with multiple parameters on
a single line.  See bug definition for details.

Added a fix in PEAR_Sniffs_Functions_FunctionDeclarationSniff for this
condition.
80fe937
@triplepoint triplepoint Update CodeSniffer/Standards/Squiz/Tests/Functions/MultiLineFunctionD…
…eclarationUnitTest.inc

Missing semicolon. Good catch @sqmk
60d37b1
@gsherwood
Squiz Labs member

Sorry, didn't see this and did my own fix for it. Took the time to re-order the logic in that IF statement so it was easier (for me at least) to read.

This was fixed in this commit: 5369695

@gsherwood gsherwood closed this Oct 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.