Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations, remove unnecessary returns, remove unused imports. #12

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Smarker
Copy link
Contributor

@Smarker Smarker commented Nov 27, 2017

This PR removes most of the warnings on intellij

image

  • Added public type annotations according to the scala style guidelines
    All public methods should have explicit type annotations. Type inference may break encapsulation in these cases, because it depends on internal method and class details. Without an explicit type, a change to the internals of a method or val could alter the public API of the class without warning, potentially breaking client code. Explicit type annotations can also help to improve compile times.

  • Removed unused import statements

  • Removed unnecessary return keywords

  • Edited scala doc comments - changed @result to @return

@sramirez sramirez merged commit 2a7831e into sramirez:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants