binary files are returned as OtherLanguage by GetLanguage

src-d · Jul 4, 2017 · d8798c2 · d8798c2
1 parent 9de4d35
commit d8798c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/common.go b/common.go
@@ -116,6 +116,10 @@ func GetLanguageBySpecificClassifier(content []byte, candidates []string, classi
 // GetLanguages applies a sequence of strategies based on the given filename and content
 // to find out the most probably languages to return.
 func GetLanguages(filename string, content []byte) []string {
+	if IsBinary(content) {
+		return nil
+	}
+
 	var languages []string
 	candidates := []string{}
 	for _, strategy := range DefaultStrategies {

diff --git a/common_test.go b/common_test.go
@@ -64,6 +64,7 @@ func (s *EnryTestSuite) TestGetLanguage() {
 		{name: "TestGetLanguage_1", filename: "foo.py", content: []byte{}, expected: "Python"},
 		{name: "TestGetLanguage_2", filename: "foo.m", content: []byte(":- module"), expected: "Mercury"},
 		{name: "TestGetLanguage_3", filename: "foo.m", content: nil, expected: OtherLanguage},
+		{name: "TestGetLanguage_4", filename: "foo.mo", content: []byte{0xDE, 0x12, 0x04, 0x95, 0x00, 0x00, 0x00, 0x00}, expected: OtherLanguage},
 	}
 
 	for _, test := range tests {