Update CLI to get the same output of linguist #41
Conversation
cli/enry/main.go
Outdated
| fmt.Printf("%s:\n", name) | ||
| for _, file := range language { | ||
| fmt.Printf("%s\n", file) | ||
| } |
cli/enry/main.go
Outdated
| fileCount[name] = len(language) | ||
| total += len(language) | ||
|
|
||
| } |
cli/enry/main.go
Outdated
| for name, language := range out { | ||
| fileCount[name] = len(language) | ||
| total += len(language) | ||
|
|
cli/enry/main.go
Outdated
| @@ -77,8 +80,17 @@ func main() { | |||
| log.Fatal(err) | |||
| } | |||
|
|
|||
| data, _ := json.MarshalIndent(out, "", " ") | |||
| fmt.Printf("%s\n", data) | |||
| if *jsonFlag && !*breakdownFlag { | |||
There was a problem hiding this comment.
maybe a switch is better here?
There was a problem hiding this comment.
I am doing these extrange ifs because linguist flags work weird, if you have JSON and breakdown flags active, only breakdown output is printed. If you have only breakdown flag active, percent output and breakout output are printed.
cli/enry/main.go
Outdated
| printBreakDown(out) | ||
| } else if *breakdownFlag { | ||
| printPercents(out) | ||
| fmt.Println() |
There was a problem hiding this comment.
maybe is better to use bytes.Buffer to generate the complete string, and then print it to stdout instead of use fmt.Println() here and into printPercents and printBreakDown functions.
cli/enry/main.go
Outdated
| printJson(out) | ||
| case *jsonFlag && *breakdownFlag: | ||
| printBreakDown(out, &buff) | ||
| fmt.Print(buff.String()) |
|
👍 awesome, I guess it just need to be rebased on master now |
|
The CI is failing due to #47 but this can be merged |
|
Squash everything into a single commit. It's a small change, so it does not need that much detail in the logs. |
|
Please, rebase. |
There are still some differences, our json is pretty printed and the percents are not the same because they use all the files in the repo and we only use the ones which are classified.
Tell me if I should change these things too.