This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Handle EOF error in commitFileIter.ForEach #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
force-pushed
the
fix/handle_eof_err
branch
2 times, most recently
from
7d0adfc to
bb4adf1
Compare
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
force-pushed
the
fix/handle_eof_err
branch
2 times, most recently
from
e3f9637 to
e536f1b
Compare
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
force-pushed
the
fix/handle_eof_err
branch
2 times, most recently
from
dfcd7f1 to
a9ac7fe
Compare
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
force-pushed
the
fix/handle_eof_err
branch
from
a9ac7fe to
d1f0897
Compare
mcuadros
suggested changes
Aug 4, 2019
| if nextErr != nil { | ||
| if nextErr == io.EOF { | ||
| break | ||
| } else if nextErr != nil { |
Contributor
There was a problem hiding this comment.
remove this unnecessary else
Contributor
Author
There was a problem hiding this comment.
Thank you for the review. I've fixed it.
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commitFileIter.ForEachalways returns io.EOF error, so the first commit in this PR fails.The second commit fixes this problem by handling io.EOF.