-
Notifications
You must be signed in to change notification settings - Fork 532
Adds ssh client to V2.0.0 #3
Conversation
clients/ssh/git_upload_pack.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the third party packages goes at the end of the import list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, TODO.
|
@alcortesm ping |
Current coverage is
|
clients/ssh/git_upload_pack.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing related to Go style, could we move the Err on all of these to the beginning? Examples:
https://golang.org/pkg/os/#pkg-variables, https://golang.org/pkg/net/http/#pkg-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to do that, should I @mcuadros ?
|
LGTM |
|
The current version does not implement the new AuthMethod functionality correctly and I have not understand what should the String() method does. @mcuadros suggested I should take a look at ssh.AuthMethod, so all of them can be passed to the SSH client. I have not fully understand all Máximo comments: I will need to think about it. Things will be much easier if the appropriate sections of go-git where documented. |
…wordCallback and PublicKeys
|
Done. But I still don't understand the purpose of having all this auth methods in go-git.client.ssh, there should be only one, that wraps a generic an externally generated []ssh.AuthMethod in a go-git.client.common.AuthMethod. Should we discuss about it? |
|
I dont understand how the your AuthMethods works, how I should set for example the credentials here: BTW can you squash |
|
I have gotten myself into a squashing hell, let's continue this PR in a new one. |
Do not allow to download file without filename in url
SSH client for go-git.v2.