Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Conversation

@alcortesm
Copy link
Contributor

SSH client for go-git.v2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the third party packages goes at the end of the import list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, TODO.

@mcuadros
Copy link
Contributor

@alcortesm ping

@codecov-io
Copy link

Current coverage is 68.51%

Merging #3 into v2.0.0 will not affect coverage as of 6d30995

@@            v2.0.0      #3   diff @@
======================================
  Files           13      13       
  Stmts          883     883       
  Branches       138     138       
  Methods          0       0       
======================================
  Hit            605     605       
  Partial         72      72       
  Missed         206     206       

Review entire Coverage Diff as of 6d30995

Powered by Codecov. Updated on successful CI builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing related to Go style, could we move the Err on all of these to the beginning? Examples:
https://golang.org/pkg/os/#pkg-variables, https://golang.org/pkg/net/http/#pkg-variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to do that, should I @mcuadros ?

@toqueteos
Copy link
Contributor

LGTM

@alcortesm
Copy link
Contributor Author

The current version does not implement the new AuthMethod functionality correctly and I have not understand what should the String() method does.

@mcuadros suggested I should take a look at ssh.AuthMethod, so all of them can be passed to the SSH client.

I have not fully understand all Máximo comments: I will need to think about it. Things will be much easier if the appropriate sections of go-git where documented.

@alcortesm
Copy link
Contributor Author

Done.

But I still don't understand the purpose of having all this auth methods in go-git.client.ssh, there should be only one, that wraps a generic an externally generated []ssh.AuthMethod in a go-git.client.common.AuthMethod. Should we discuss about it?

@mcuadros
Copy link
Contributor

I dont understand how the your AuthMethods works, how I should set for example the credentials here:
https://github.com/src-d/go-git/pull/3/files#diff-93a872f722160e3c55c4194ccfb29664R57ç

BTW can you squash

@alcortesm
Copy link
Contributor Author

I have gotten myself into a squashing hell, let's continue this PR in a new one.

@alcortesm alcortesm mentioned this pull request Nov 17, 2015
@alcortesm alcortesm closed this Nov 17, 2015
@alcortesm alcortesm deleted the v2.0.0 branch November 17, 2015 16:02
gsalingu-ovhus pushed a commit to gsalingu-ovhus/go-git that referenced this pull request Mar 28, 2019
Do not allow to download file without filename in url
Nolaireon pushed a commit to Nolaireon/go-git that referenced this pull request Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants