This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Added support for objfile format #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Old name accidentally shadowed builtin close function
Current coverage is
|
| } | ||
|
|
||
| // Valid returns true if t is a valid ObjectType. | ||
| func (t ObjectType) Valid() bool { |
Contributor
Author
There was a problem hiding this comment.
I meant to use this to check the validity of the provided object type in objfile.NewWriter. I'll update the PR.
Object types default to 0, which is an invalid value, so I added this function for a consistent way to check that someone didn't forget to provide a valid value.
Contributor
Author
There was a problem hiding this comment.
objfile.NewWriter has been updated to use this function now.
Contributor
|
Awesome work. Looks greats. |
mcuadros
added a commit
that referenced
this pull request
Feb 27, 2016
Added support for objfile format
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
Added support for objfile format
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Webapp coding style and comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for the loose object file format used on disk when objects aren't packed. This is a necessary component for the implementation of #19.
This changeset also fixes an accidental shadowing of the bultin close function introduced in e2c9ad1.