Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: diff, skip useless rune->string conversion #873

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@smola
Copy link
Member

smola commented Jun 26, 2018

According to library documentation :
https://github.com/sergi/go-diff/blob/master/diffmatchpatch/diff.go#L391

(Sent by Marc on the go-git Slack channel)

utils: diff, skip useless rune->string conversion
According to library documentation :
https://github.com/sergi/go-diff/blob/master/diffmatchpatch/diff.go#L391

Signed-off-by: Marc Barussaud <marc.barussaud@orange.com>

@mcuadros mcuadros merged commit fcfd239 into src-d:master Jun 27, 2018

3 checks passed

codecov/project 76.91% (+0%) compared to 662e2c2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smola smola deleted the smola:fix-diff branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.