Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

plumbing/format: gitignore, fixed an edge case for .gitignore #924

Merged
merged 1 commit into from Aug 20, 2018

Conversation

fkorotkov
Copy link
Contributor

Fixes #923

Fixes src-d#923

Signed-off-by: Fedor Korotkov <fedor.korotkov@gmail.com>
@fkorotkov
Copy link
Contributor Author

Hey @smola and @mcuadros, as a persons who response on PRs and approved my last PR,

This might be a pretty big issue. Because of gitignore excluding the wrong files, hard reset can leave dirty worktree as described in #923. Also git status is not working properly in such cases. I bet some other things are not working as well.

/cc @osklyar as an author of pattern matcher

@fkorotkov
Copy link
Contributor Author

BTW it doesn't look like CI is failing because of this change.

@mcuadros mcuadros changed the title Fixed an edge case for .gitignore plumbing/format: gitignore, fixed an edge case for .gitignore Aug 20, 2018
@mcuadros mcuadros merged commit 1cef577 into src-d:master Aug 20, 2018
@mcuadros
Copy link
Contributor

Thanks! Nice catch.

@fkorotkov fkorotkov deleted the fedor/fix-issue-923 branch August 20, 2018 11:48
@fkorotkov
Copy link
Contributor Author

@mcuadros thanks! Unfortunately it didn't make it to 4.6.0 release. When do you plan 4.6.1? 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants