New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: PlainClone with Basic Authentication (Password & Access Token) #990

Merged
merged 9 commits into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@mccurdyc
Contributor

mccurdyc commented Oct 19, 2018

Proposed Additions

  • Add a GoDoc example for cloning with BasicAuth
  • Add a GoDoc example for cloning with "Token" Auth
  • Add cli example for cloning with BasicAuth to _examples
  • Add cli example for cloning with "Token" Auth

mccurdyc added some commits Oct 19, 2018

git_test: Added GoDoc examples for cloning with BasicAuth and TokenAuth.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
_examples: Added cli example for cloning with BasicAuth.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
_examples: Added cli example for cloning with TokenAuth.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
git_test: Updated GoDoc examples to pass tests.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
@mccurdyc

This comment has been minimized.

Contributor

mccurdyc commented Oct 19, 2018

Why does TokenAuth not work?

If this is something that would be of value, and there isn't a specific reason why it hasn't been implemented, I would love to deep dive into this. I think it would be a great follow-up, then we could clean up the "Token" auth.

@mccurdyc mccurdyc changed the title from PlainClone with Basic and "Token" Authentication to examples & documentation: PlainClone with Basic and "Token" Authentication Oct 19, 2018

@mcuadros mcuadros requested a review from smola Oct 23, 2018

@smola

This comment has been minimized.

Member

smola commented Oct 24, 2018

@mccurdyc Does TokenAuth not work? It was added to support OAuth and it seemed to work, at least in Bitbucket, #859

If we are talking about GitHub's personal access tokens, using them as password is the intended usage: https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/#using-a-token-on-the-command-line

mccurdyc added some commits Oct 24, 2018

git_test: Updated PlainClone with BasicAuth examples' names.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
_examples: Moved and updated comments in BasicAuth cli examples.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
_examples: Moved and updated comments in BasicAuth cli examples.
Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>

@mccurdyc mccurdyc changed the title from examples & documentation: PlainClone with Basic and "Token" Authentication to examples & documentation: PlainClone with Basic Authentication (Password & Access Token) Oct 24, 2018

@mccurdyc

This comment has been minimized.

Contributor

mccurdyc commented Oct 24, 2018

@smola I apologize, I was incorrectly using the GitHub personal access token.

Also, thank you for including the link to the GitHub document!

I will try using OAuth with GitHub and BitBucket and document and provide examples where necessary.

@mccurdyc

This comment has been minimized.

Contributor

mccurdyc commented Oct 24, 2018

Also, I understand that "Yes" is forever and "No" is temporary, so, please let me know how I can improve this PR (e.g., directory structure, comments, naming, etc.)

@smola

smola approved these changes Oct 24, 2018

@smola

This comment has been minimized.

Member

smola commented Oct 24, 2018

Looks good to me, thanks!

I apologize, I was incorrectly using the GitHub personal access token.

Common issue, since it is not documented ;-)

@mcuadros

This comment has been minimized.

Member

mcuadros commented Oct 24, 2018

_examples: Adding password and GitHub personal access token cloning t…
…o the list of examples.

Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
@mccurdyc

This comment has been minimized.

Contributor

mccurdyc commented Oct 24, 2018

@mcuadros I have added those to the list of examples. Thanks!

@mcuadros mcuadros changed the title from examples & documentation: PlainClone with Basic Authentication (Password & Access Token) to examples: PlainClone with Basic Authentication (Password & Access Token) Oct 25, 2018

@mcuadros mcuadros merged commit cde0367 into src-d:master Oct 25, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@mccurdyc mccurdyc deleted the mccurdyc:mccurdyc/clone-auth-examples branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment