ensure all virtual columns are added in inserts and updates #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a parent Parent has many Child and Child does not have any inverse relationship, the FK of Child it's not saved, even though it is a virtual column. That's why only virtual columns for explicit relationships were being added during the code generation step. This, however, has changed so all of the virtual columns of a record are added in inserts and updates (only once, of course). Therefore, now relationships with no inverse relationships at all can be used.
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 81.29% 81.24% -0.05%
==========================================
Files 16 16
Lines 3410 3433 +23
==========================================
+ Hits 2772 2789 +17
- Misses 434 438 +4
- Partials 204 206 +2
Continue to review full report at Codecov.
|
Serabe
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a parent Parent has many Child and Child does not have any
inverse relationship, the FK of Child it's not saved, even though
it is a virtual column. That's why only virtual columns for explicit
relationships were being added during the code generation step.
This, however, has changed so all of the virtual columns of a record
are added in inserts and updates (only once, of course).
Therefore, now relationships with no inverse relationships at all
can be used.
This fixes one of the bugs reported in #170