-
Notifications
You must be signed in to change notification settings - Fork 101
use verbatim license texts #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The final text where we were adding year and copyright holder name is just *an appendix about how to add a notice*, not the notice itself. As found in https://www.apache.org/licenses/LICENSE-2.0.txt Signed-off-by: Santiago M. Mola <santi@mola.io>
As found in https://www.gnu.org/licenses/gpl-3.0.txt Signed-off-by: Santiago M. Mola <santi@mola.io>
As found tin https://creativecommons.org/licenses/by-sa/4.0/legalcode.txt Signed-off-by: Santiago M. Mola <santi@mola.io>
vmarkovtsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 as long as it is legally valid.
|
@vmarkovtsev it is legally valid in terms of |
|
Can you clarify how this works? I don't like the idea of having headers. |
|
@mcuadros IANAL (this would require a lawyer/expect confirmation before acting on it, do not hold me accountable for legal decisions!), here's my understanding: A copyright notice is required to apply a license properly. These are the existing options, which are not mutually exclusive, more than one can be combined:
But clearly, the Apache/GPL LICENSE text itself is not a copyright notice, and the appendix of the Apache License isn't either. |
|
Let's use NOTICE + LICENSE file. |
|
Is this ready to be merged? |
|
@dpordomingo Nope. Closing. The definitive version of this was absorbed by #273 |
We are adding copyright holder name and year to the licenses text.
But instead of adding a copyright notice, we were just editing
appendixes with instructions about adding the notice, not the notice
itself. This is not valid.
Copyright notice is usually added to source code file headers in comments,
to README or to a NOTICE file.
See some examples of applying these licenses:
Apache Foundation uses the verbatim text (without replacing anything), then
they add copyright headers to files, see:
https://github.com/apache/spark
https://github.com/apache/httpd
Android uses a custom NOTICE file, where they add their copyright notice,
and then they add Apache License 2.0 terms and conditions without the appendix, see:
https://android.googlesource.com/platform/dalvik/+/froyo/NOTICE
https://android.googlesource.com/platform/dalvik/+/master/NOTICE
Since hacktoberfest started, we got a lot of pull requests changing from verbatim licenses to these versions, or updating the year. I've closed most of them since they're pointless, but it would be better if we sort this out in the guide to avoid future confusion.