Skip to content

Conversation

@smola
Copy link
Contributor

@smola smola commented Oct 31, 2018

We are adding copyright holder name and year to the licenses text.
But instead of adding a copyright notice, we were just editing
appendixes with instructions about adding the notice, not the notice
itself. This is not valid.

Copyright notice is usually added to source code file headers in comments,
to README or to a NOTICE file.

See some examples of applying these licenses:

Since hacktoberfest started, we got a lot of pull requests changing from verbatim licenses to these versions, or updating the year. I've closed most of them since they're pointless, but it would be better if we sort this out in the guide to avoid future confusion.

smola added 2 commits October 31, 2018 12:52
The final text where we were adding year and copyright holder name
is just *an appendix about how to add a notice*, not the notice itself.

As found in https://www.apache.org/licenses/LICENSE-2.0.txt

Signed-off-by: Santiago M. Mola <santi@mola.io>
As found in https://www.gnu.org/licenses/gpl-3.0.txt

Signed-off-by: Santiago M. Mola <santi@mola.io>
@smola smola requested a review from mcuadros October 31, 2018 11:57
@smola smola requested a review from jorgeschnura as a code owner October 31, 2018 11:57
@smola smola changed the title use verbatim licenses texts use verbatim license texts Oct 31, 2018
@smola smola mentioned this pull request Oct 31, 2018
Copy link
Collaborator

@vmarkovtsev vmarkovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as long as it is legally valid.

@smola
Copy link
Contributor Author

smola commented Nov 5, 2018

@vmarkovtsev it is legally valid in terms of LICENSE text, however, I think we still need to include a proper copyright notice to our projects (either source code headers, NOTICE file, explicit LICENSE appendix or README.md, I'm not sure where).

@mcuadros
Copy link
Contributor

mcuadros commented Nov 6, 2018

Can you clarify how this works? I don't like the idea of having headers.

@smola
Copy link
Contributor Author

smola commented Nov 6, 2018

@mcuadros IANAL (this would require a lawyer/expect confirmation before acting on it, do not hold me accountable for legal decisions!), here's my understanding:

A copyright notice is required to apply a license properly. These are the existing options, which are not mutually exclusive, more than one can be combined:

  • A copyright notice can be embedded with the license text itself. This is quite common in very short licenses (MIT example, BSD-3 example.
  • Use a NOTICE file including the copyright notice, including any required notice about 3rd party licenses. This is what Apache Foundation does.
  • Adding it at the bottom of README?
  • Add a copyright notice to the header of each file, in a comment. This is recommended by the FSF and ASF. It is not required for the license to have effect, it is just a recommendation to remove some legal uncertainties.

But clearly, the Apache/GPL LICENSE text itself is not a copyright notice, and the appendix of the Apache License isn't either.

@mcuadros
Copy link
Contributor

mcuadros commented Nov 7, 2018

Let's use NOTICE + LICENSE file.

@dpordomingo
Copy link
Contributor

dpordomingo commented Dec 14, 2018

Is this ready to be merged?

@smola
Copy link
Contributor Author

smola commented Dec 17, 2018

@dpordomingo Nope. Closing. The definitive version of this was absorbed by #273

@smola smola closed this Dec 17, 2018
@smola smola deleted the verbatim-licenses branch December 17, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants