Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable race detection on test run, fix race condition #232
Please feel free to close this if avoiding race conditions aren't a priority, but I noticed my
If the build for this PR fails (it does locally on my machine) I'll open a ticket about resolving concurrency issues.
Here's what I get when I run hercules' tests on my machine:
update 2: working on resolving race conditions, so hopefully this will close #233 as well
Not sure what happened with one of the build jobs: https://travis-ci.com/src-d/hercules/jobs/183188633
Hi @bobheadxi thanks so much for your contribution. That build failed because of an annoying problem in Travis environment related to networking:
I restarted that job. I have recently had to restart it 5 times before that error goes away, which is very annoying. We are thinking with @smola what can be done to resolve it.