Lookout verbose option

[smacker]

Second (zero) part of #29

[bzz]

Do you think there is a value to have some logs printed for opening/closing a connection in non-verbose mode?

Right now experience using time ./lookout review ipv4://localhost:10302 is a bit confusing - after running it, one needs to wait ~3-4sec when nothing happens until BEGIN RESULT shows up.

Suggestion:

1. Success

Connected to analyzer at XXX
Sending NotifyReview request
BEGIN RESUL

if something like this is printed, a user would have more patience.

2. Failure
   Right now, if time ./lookout review ipv4://localhost:666 just has no feedback to user at all.
   Suggestion:

Failed to connect to analyzer at XXX
Retrying (1 out of Y)
...
Failed to connect to analyzer at XXX
Retrying (2 out of Y)

Having both of those is important part of SDK: it would allow to wave the mistakes related to networking for a user and thus will help building trust in SDK (he does not need to check with nc manually if server is reachable, etc)

Also, do you think there is a value of applying same -v for dummy analyzer as well?
May be does not need to be that detailed, but may be nice to have

[bzz]

Failure to connect to analyzer without -v it's very hard to identify: does it taking to long? does it fail to connect?

[smacker]

@bzz

Failure to connect to analyzer without -v it's very hard to identify: does it taking to long? does it fail to connect?

this is why commits are in opposite order to issue bullets.

With the prev commit it will fail fast with correct error.

Failed to connect to analyzer at XXX
Retrying (1 out of Y)

we removed it in prev commit

Connected to analyzer at XXX
Sending NotifyReview request

would be nice 👍 let's update issue/create new one with description of proper success logging across binaries and implement it.

[bzz]

Got it, thank you for explaining - assume you are talking about #34

would be nice 👍 let's update issue/create new one with description of proper success logging across binaries and implement it.

Improving in separate issue sounds good - would you please create one so the feedback is not getting lost?

[bzz]

SGTM, after issue for logging is created

[smacker]

rebased on master. Merge after CI is green.