Remove JSON keys sort #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristan Kalos <tristan.kalos@live.fr>
vmarkovtsev
requested changes
May 18, 2019
Collaborator
vmarkovtsev
left a comment
vmarkovtsev
left a comment
There was a problem hiding this comment.
We should always sort the keys
| os.remove(index) | ||
| self._log.info("Writing the new index.json ...") | ||
| with open(index, "w") as _out: | ||
| json.dump(self.contents, _out, sort_keys=True, indent=4) |
Collaborator
There was a problem hiding this comment.
Are you sure that we rely on the order of the keys? There is a special "default" key as far as I remember.
Anyway, even if we do rely on the order, that's an error and we should fix the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.