Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing `completion` command on Windows #169

Closed
se7entyse7en opened this issue Jul 30, 2019 · 3 comments · Fixed by src-d/go-cli#20 or #222 · May be fixed by src-d/go-cli#21

Comments

@se7entyse7en
Copy link
Member

commented Jul 30, 2019

While investigating #168.

The completion command is specific to bash. Given that we've been testing sourced-ce with powershell as we used to do for engine, it makes sense to remove it for Windows.

@dpordomingo

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

I think we should move this to https://github.com/src-d/go-cli
wdyt @smola ?

smacker added a commit to smacker/go-cli that referenced this issue Aug 1, 2019
Remove completion command on Windows
Fix: src-d/sourced-ce#169

The completion command is specific to bash but we use go-cli on windows
with powershell as well.

Signed-off-by: Maxim Sukharev <max@smacker.ru>

@smacker smacker self-assigned this Aug 1, 2019

@carlosms

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Reopening because src-d/go-cli#20 does not fix this one until we update the version in go.mod

@carlosms carlosms reopened this Aug 13, 2019

dpordomingo added a commit to dpordomingo/go-cli that referenced this issue Aug 13, 2019
Remove completion command on Windows
Fix: src-d/sourced-ce#169

The completion command is specific to bash but we use go-cli on windows
with powershell as well.

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
smacker added a commit to smacker/sourced-ce that referenced this issue Aug 13, 2019
Update go-cli dependency
Fix: src-d#169

Signed-off-by: Maxim Sukharev <max@smacker.ru>
dpordomingo added a commit to dpordomingo/go-cli that referenced this issue Aug 13, 2019
Remove completion command on Windows
Fix: src-d/sourced-ce#169

The completion command is specific to bash but we use go-cli on windows
with powershell as well.

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Since we're not using cli.New, but cli.NewNoDefaults, and then we're manually adding the cli.CompletionCommand, I think that the fix provided by src-d/go-cli#20 won't solve our problem.

src-d/go-cli#21 should solve our problem.

@dpordomingo dpordomingo self-assigned this Aug 13, 2019

@dpordomingo dpordomingo added the bug label Aug 13, 2019

smacker added a commit to smacker/sourced-ce that referenced this issue Aug 20, 2019
Remove completion subcommand on windows
Fix: src-d#169

Signed-off-by: Maxim Sukharev <max@smacker.ru>
@smacker smacker referenced this issue Aug 20, 2019
1 of 2 tasks complete
smacker added a commit to smacker/sourced-ce that referenced this issue Aug 23, 2019
Remove completion subcommand on windows
Fix: src-d#169

Signed-off-by: Maxim Sukharev <max@smacker.ru>

@smacker smacker closed this in #222 Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.