Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document error handling #155

Merged
merged 3 commits into from Jul 19, 2019
Merged

Document error handling #155

merged 3 commits into from Jul 19, 2019

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Jul 18, 2019

fix #143
more info Error Handling DD [internal link]

I split troubleshooting in two, and pushed against my fork to make it easier the review:

@dpordomingo dpordomingo added the enhancement New feature or request label Jul 18, 2019
@dpordomingo dpordomingo self-assigned this Jul 18, 2019
@dpordomingo dpordomingo requested a review from a team July 18, 2019 14:18
@dpordomingo
Copy link
Contributor Author

this is now ready to be reviewed

- faq&troubleshooting was divided into faq and troubleshooting
- docs about logs were moved to troubleshooting
- docs about how to deal with errors were added to troubleshooting

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo changed the title [WIP] document error handling Document error handling Jul 18, 2019
docs/faq.md Outdated Show resolved Hide resolved
docs/troubleshooting.md Outdated Show resolved Hide resolved
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
docs/troubleshooting.md Show resolved Hide resolved
docs/troubleshooting.md Show resolved Hide resolved
Copy link

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we were already using title-case in previous version, and it's actually in our documentation guide 😂

docs/troubleshooting.md Show resolved Hide resolved
@dpordomingo dpordomingo merged commit 7d3e9ad into src-d:master Jul 19, 2019
@dpordomingo dpordomingo deleted the troubleshooting branch July 19, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document error scenarios in troubleshooting
4 participants