Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility of empty resourse limits #227

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@smacker
Copy link
Member

commented Aug 27, 2019

Fix: #225

We changed syntax of defaults values in docker-compose.yml from
${VAR:-default} to ${VAR-default}. We can't pass empty strings for
float numbers with such syntax anymore.

Signed-off-by: Maxim Sukharev max@smacker.ru


  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file
Fix incompatibility of empty resourse limits
Fix: #225

We changed syntax of defaults values in `docker-compose.yml` from
`${VAR:-default}` to `${VAR-default}`. We can't pass empty strings for
float numbers with such syntax anymore.

Signed-off-by: Maxim Sukharev <max@smacker.ru>

@smacker smacker requested a review from src-d/applications Aug 27, 2019

Update changelog
Signed-off-by: Maxim Sukharev <max@smacker.ru>

@smacker smacker merged commit 33f131e into src-d:master Aug 27, 2019

3 checks passed

DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 64.83% (+0.09%) compared to 13f36af
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.