Fix for LP: #579319

GNUSim8085 · May 25, 2010 · df5ea99 · df5ea99
1 parent 9a8c3ed
commit df5ea99
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-25  Onkar Shinde  <onkarshinde@gmail.com>
+
+	* src/support.c: Fix stupid mistake - trying to access message from
+	null error object. Remove the corresponding variable as it is never
+	initialized. Fixes LP: #579319.
+
 2010-05-23  Onkar Shinde  <onkarshinde@gmail.com>
 
 	* po/it.po: Updated Italian translation from launchpad.

diff --git a/NEWS b/NEWS
@@ -1,5 +1,7 @@
 GNUSim8085 1.3.7 (UNRELEASED)
 
+Fix:     LP: #579319 - Help -> about = crash
+
 Translations:
          New - Brazilian Portuguese (pt_BR), Greek (el).
          Updated - Gujarati (gu), Kannada (kn), Italian (it), Spanish (es).

diff --git a/src/support.c b/src/support.c
@@ -110,7 +110,6 @@ gchar**
 read_authors (){
   gchar *pathname = NULL;
   gchar **authors;
-  GError *error = NULL;
   FILE *fp;
   GString *gstr;
   char *ret;
@@ -131,7 +130,6 @@ read_authors (){
   if (fp == NULL)
     {
 	  GString *str;
-          error = NULL;
           pathname = NULL;
           str = g_string_new("");
           g_string_append(str, "AUTHORS");
@@ -142,9 +140,8 @@ read_authors (){
 
   if (fp == NULL)
     {
-      fprintf (stderr, "Failed to load authors file: %s: %s\n",
-               pathname, error->message);
-      g_error_free (error);
+      fprintf (stderr, "Failed to load authors file: %s\n",
+               pathname);
       return NULL;
     }