Python 2.5 Support #25

Open
wants to merge 13 commits into
from

Conversation

Projects
None yet
2 participants
@mcos

mcos commented Mar 22, 2013

Some of our servers are still on Python 2.5 and I wanted to get a profile of Redis on these servers using this tool. Here are some of the changes I made:

  • If the io module isn't present, use StringIO
  • If the json modulle isn't present, use simplejson
  • Install simplejson as a prerequisite in requirements.txt
  • Added a utils directory with a namedtuple implementation
  • Used array from the array module with a type of unsigned char if the bytearray type isn't available.
  • Used StringIO from the StringIO module if BytesIO from the io module isn't available

All tests pass on Python 2.5, 2.6 and 2.7.

I completely understand if you don't wish to pull in these changes, given that Python 2.5 support is extra work, I'm just happy to contribute in any way I can.

Thanks,
-Mark

@sripathikrishnan

This comment has been minimized.

Show comment Hide comment
@sripathikrishnan

sripathikrishnan Apr 3, 2013

Owner

@mcos - wow, thanks for the excellent pull request! Also, my apologies for taking so long to respond, I have been busy at work lately.

I am a bit torn on including this pull request. It just feels added maintenance to me. Especially since this isn't server software, it should be easy to copy the dump.rdb file and run commands locally.

I will keep this pull request open. If other folks need support for 2.5, I will gladly merge it and commit to supporting 2.5 in future iterations. Also, I will update the FAQ to mention that 2.5 support is available in your repository.

Thank you for putting so much detail in the pull request, and I am sorry for not including this at this time.

Owner

sripathikrishnan commented Apr 3, 2013

@mcos - wow, thanks for the excellent pull request! Also, my apologies for taking so long to respond, I have been busy at work lately.

I am a bit torn on including this pull request. It just feels added maintenance to me. Especially since this isn't server software, it should be easy to copy the dump.rdb file and run commands locally.

I will keep this pull request open. If other folks need support for 2.5, I will gladly merge it and commit to supporting 2.5 in future iterations. Also, I will update the FAQ to mention that 2.5 support is available in your repository.

Thank you for putting so much detail in the pull request, and I am sorry for not including this at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment