From 935526c98df935ab400d20002a61a560ee101b66 Mon Sep 17 00:00:00 2001 From: Karim Radhouani Date: Fri, 27 Nov 2020 18:05:41 +0800 Subject: [PATCH] pull image before creating timeout ctx --- clab/docker.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/clab/docker.go b/clab/docker.go index 0b5e2a0b2..f66dc50e4 100644 --- a/clab/docker.go +++ b/clab/docker.go @@ -146,6 +146,11 @@ func (c *cLab) DeleteBridge(ctx context.Context) (err error) { func (c *cLab) CreateContainer(ctx context.Context, node *Node) (err error) { log.Infof("Create container: %s", node.ShortName) + err = c.PullImageIfRequired(ctx, node.Image) + if err != nil { + return err + } + nctx, cancel := context.WithTimeout(ctx, c.timeout) defer cancel() labels := map[string]string{ @@ -162,11 +167,6 @@ func (c *cLab) CreateContainer(ctx context.Context, node *Node) (err error) { labels["group"] = node.Group } - err = c.PullImageIfRequired(nctx, node.Image) - if err != nil { - return err - } - cont, err := c.DockerClient.ContainerCreate(nctx, &container.Config{ Image: node.Image,