Raise visible errors when Git pull fails #128

Open
jasim opened this Issue Mar 6, 2012 · 1 comment

Projects

None yet

2 participants

@jasim
Contributor
jasim commented Mar 6, 2012

Goldberg does not run any build if Git pull fails. There is no notification so it is hard to figure out what went wrong.

A typical case where this happens is:
schema.rb is checked in. A new commit is made which has a migration; but this commit does not check in the updated schema.rb. Goldberg will at this point run the migration which will create a locally modified version (in the CI server) of the schema.rb. Next time Goldberg tries to pull - the conflict in schema.rb will cause it to fail.

@srushti
Owner
srushti commented Jul 25, 2012

The git pull issue specifically has been fixed since we do a hard reset before pulling now. But, this probably should still be done to account for scenarios where the version control server is not reachable (or other similar error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment