Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Portability issues / suggestions #143
I'm running Goldberg on FreeBSD, which works nicely, however, a few things that I stumbled upon:
I had to add the following to the Gemfile
Bash comes usually only by default in Linux distros - although available for pretty much all decent operating systems, Goldberg makes very few uses of the shell, so sticking to plain old 'sh' syntax (symlinked to bash, anyways, on most Linuxes) is more portable:
Same goes for script/goldberg-build, where the shebang line should use sh, and the 'return -1' statements should be 'return 1' or so - sorry for not having a patch, I wasn't sure if you use -1 specifically for something, ... so just pointing it out.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
@Cslag, About the bash thing:
While the script itself is not using any BASHisms, rvm is documented not to work with bourne shell or dash (yuck)
Good news. rvm-auto-ruby seems like the new way to run code in a particular ruby, and works pretty much like rbenv shims. Unfortunately, I don't have an rvm machine to test it on.
If we can use rvm-auto-ruby instead of rvm use, then we can get rid of the BASH dependency.