New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for hanging indentation of args in the signature popup #235

Merged
merged 2 commits into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@vshotarov
Copy link
Contributor

vshotarov commented Feb 3, 2018

Hi @srusskih,

Similar to #227 and #229, I noticed the function signature in the markdown popup doesn't behave well with hanging indentation of arguments.

To overcome this, I have used the ''.join(args.split()) method to remove spaces, but instead of using split() I had to use a regular expression (which I got from this answer at StackOverflow), in order to respect spaces inside string default values.

Additionally, I've added a .replace(',', ', ') function to bring back the spaces between the arguments.

This is my first ever PR, so please feel free to flag up issues and/or offer guidance.

Thank you!

Example

sublimejedi_hanging_docstring_fix

@srusskih

This comment has been minimized.

Copy link
Owner

srusskih commented Feb 5, 2018

@vshotarov welcome :)

Thanks for PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment