Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with relative path move-to #16

Closed
andydotxyz opened this issue Feb 8, 2020 · 2 comments
Closed

Issue with relative path move-to #16

andydotxyz opened this issue Feb 8, 2020 · 2 comments

Comments

@andydotxyz
Copy link
Contributor

I noticed that in some cases the relative move-to 'm' command seems to be incorrect.
For example the svg flile at https://fonts.gstatic.com/s/i/materialicons/skip_previous/v4/24px.svg should be the mirror image of https://fonts.gstatic.com/s/i/materialicons/skip_next/v4/24px.svg but the arrow's middle point is offset on Y value for some reason.

I could not find a fix quickly or I would have submitted a PR, sorry.

@srwiley
Copy link
Owner

srwiley commented Mar 11, 2020

Good one. I think I got it. When the current cursor location was not at the start of the path and a close path, Z command, was called, the current location was not being updated to the start of the path. Should be OK now in the latest commit.

@srwiley srwiley closed this as completed Mar 11, 2020
@andydotxyz
Copy link
Contributor Author

Perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants