Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction support #37

Merged
merged 1 commit into from Sep 22, 2021
Merged

Transaction support #37

merged 1 commit into from Sep 22, 2021

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Sep 22, 2021

This adds the ability to make sure that several pieces of data are written to disc at the same time. We need this support for indexed replication in EBT where you will receive both the index + the indexed message at the same time and need to make sure that we write the messages to disc in one go so that local db2 indexes will see the messages at the same time and also that EBT can expect that if it sees an index that the indexed message will be there. Lastly if it crashes in the middle, that we can use the index to know that we for sure will also have the indexed message stored. Basically we need to add things in what amounts to a transaction :-)

@arj03 arj03 requested a review from staltz September 22, 2021 13:05
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems wrong to me, good job. I really hope it's not possible to break this transaction semantics, I can't predict how it would be possible

@arj03 arj03 merged commit 7a38a2a into master Sep 22, 2021
@arj03 arj03 deleted the transaction branch September 22, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants