chore: upgrade go deps #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentral1se
force-pushed
the
upgrade-go-deps
branch
from
4ec988a to
16333ad
Compare
|
There is a new API for roaring bitmaps which seem more performant but it's a bit unclear how to implement a reverse iterator now. I've left a comment the PR that removed that API in dgraph-io/sroar#19 (comment) and will keep digging... edit: I've implemented the reverse in d7dc827 by converting the iterator to an array and reversing. Since the previous implementation of the iterator already did the conversion internally, this seems fine as it achieves the same performance as before. If I hear more back from https://discuss.dgraph.io/t/how-to-implement-a-reverse-roaring-bitmap-iterator-sroar-bitmap-newreverseiterator-went-away/17901 I will revise the commit. |
decentral1se
force-pushed
the
upgrade-go-deps
branch
from
16333ad to
d7dc827
Compare
|
@staltz build is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some manual work to migrate URLs and upgrade packages in a specific order due churn...
Perhaps dependabot can also help with this going forward?#177