Skip to content

Conversation

@Happy0
Copy link
Contributor

@Happy0 Happy0 commented Dec 13, 2018

Bump to version of patchcore which changes the behaviour when hovering over avatars to display the user's display name as well as their ID.

Note: this removes the about/html/link depject module since this is
exposed by patchcore (with the new behaviour.)

ssbc/patchcore#76 (commit f3613c3af31488ec38f9cdd73d0353e7d9a7a559)

over avatars to display the user's display name as well as their ID.

Note: this removes the about/html/link depject module since this is
exposed by patchcore (with the new behaviour.)

ssbc/patchcore#76 (commit f3613c3af31488ec38f9cdd73d0353e7d9a7a559)
Copy link
Contributor

@christianbundy christianbundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Happy0
Copy link
Contributor Author

Happy0 commented Dec 13, 2018

haha, thanks. nice emoticon :D

@Happy0 Happy0 merged commit eac6d48 into master Dec 13, 2018
@mixmix
Copy link
Member

mixmix commented Dec 18, 2018

@Happy0 love this behaviour. There was one regression, which was that this added @ in front of all the names! So I've gone and changed that in patchcore so the behaviour is what it used to be in patchbay.

I made a mess of the git commits in the patchcore, don't look ):

@mixmix mixmix deleted the about_link branch December 18, 2018 19:37
@Happy0
Copy link
Contributor Author

Happy0 commented Dec 18, 2018

@mixmix sorry about that! I actually wondered if I'd done that... I was like 'was that always like that? ... Well, mix did make some styling changes recently... ' I should have listened to my paranoia, haha :p.

Thanks for sorting it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants