Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchwork prompting to setup new profile on every load in latest master #1015

Closed
mmckegg opened this issue May 1, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@mmckegg
Copy link
Member

commented May 1, 2019

Screen Shot 2019-05-02 at 10 07 28 AM

This dialog is popping up on startup, but otherwise it seems to be fine.

@black-puppydog

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

Yes, this has snuck in with one of the latest commits. I noticed it first when testing #1010 but I didn't look into which commit causes this.

@christianbundy christianbundy added the bug label May 2, 2019

@christianbundy christianbundy self-assigned this May 2, 2019

@christianbundy

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Looks like sbot.id is now undefined, but we're not handling the error correctly. Found with:

diff --git a/main-window.js b/main-window.js
index 92e32485..7268135a 100644
--- a/main-window.js
+++ b/main-window.js
@@ -61,7 +61,11 @@ module.exports = function (config) {
 
   // prompt to setup profile on first use
   onceTrue(api.sbot.obs.connection, (sbot) => {
+      console.log('sbot', sbot)
+      console.log('sbot.id', sbot.id)
     sbot.latestSequence(sbot.id, (_, key) => {
+      console.log(_)
+      console.log(sbot.key)
       if (key == null) {
         api.profile.sheet.edit({ usePreview: false })
       }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.