own replies take longer to appear after patchwork has been running for a while [MEMORY LEAK!!!]

[mmckegg]

Looks like the flume indexes are slowing down over time.

How could this be possible? @dominictarr

[mmckegg]

Okay I figured it out. It is because of all of the watchers added to every single message's backlinks that is currently being displayed in a feed. Possibly the old ones aren't getting cleaned up. The sbot heap gets filled with GBs of closures for all of the substreams. Nasty.

The heap was up to 3 GB! WTF!

Probably patchwork's fault.

[mmckegg]

So that helped, but sbot heap is still growing. Seems to be triggered by reconnects.

[mmckegg]

Looking at the heap dump, it mostly appears to be closure junk left over from pull-streams. It appears a lot of streams are getting left lying around. I wonder if it is a leak, or actual streams that are still active?

[mmckegg]

Looks like this was actually caused by ssbc/packet-stream#10

I guess the "fix" is stopping end callbacks from firing and so the code to clean up realtime feed pull streams never runs:

https://github.com/ssbc/scuttlebot/blob/master/plugins/replicate/legacy.js#L177

Whoops. So in that case looks like ssbc/packet-stream#10 was a bad idea. But removing it brings back that dreaded locking.

[mmckegg]

This problem has been addressed in #597 and fixed the original issue by updating to electron 1.8.1. Closing! 🎉