Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue with har-validator 5.1.2 #897

Closed
Aversiste opened this issue Dec 6, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@Aversiste
Copy link

commented Dec 6, 2018

Hello,

I tried to build patchwork from the master branch using the § build from source section of the README. Please excuse me in advance for inaccuracies here, this is first time I use npm, or a real javascript project.

The npm install command fails with the following error:

npm ERR! 404 Not Found: har-validator@5.1.2

The har-validator package is a dependency of request, which is a dependency of nugget, which is a dependency of electron-download, itself a dependency of electron ; so I am not even sure this is the right Github project to open an issue on. Anyway, the version 5.1.2 doesn't exist according to npm registry. The closet existing versions are 5.1.0 and 5.1.3.

What can I do ?

@cryptix

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

Hmmm.. weird. Can you give use a npm ls har-validator? Or the debug log from npm? I’m not sure where this comes from or why it doesn’t pick the latest patch release...

@christianbundy

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

Could you try npm ci? We have a lockfile so you should be able to use the exact same dependency tree.

@christianbundy christianbundy added the bug label Dec 6, 2018

@Aversiste

This comment has been minimized.

Copy link
Author

commented Dec 6, 2018

@cryptix:

$ npm ls har-validator
ssb-patchwork@3.12.0-dev /home/tleguern/others/js/patchwork
└── (empty)

I uploaded npm log here.

@christianbundy:

$ npm ci                                                               
npm WARN prepare removing existing node_modules/ before installation
npm ERR! code E404
npm ERR! 404 Not Found: har-validator@5.1.2

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/tleguern/.npm/_logs/2018-12-06T17_13_48_544Z-debug.log

I uploaded resulting npm log file here.

@christianbundy

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

Looks like someone unpublished that module and broke the build. I'll push a PR to fix this now, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.