Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile sheet edit issue with undefined id #1017

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
2 participants
@christianbundy
Copy link
Member

commented May 2, 2019

Resolves #1015

@christianbundy christianbundy added the bug label May 2, 2019

@christianbundy christianbundy requested review from mmckegg and black-puppydog May 2, 2019

@christianbundy christianbundy self-assigned this May 2, 2019

@mmckegg

mmckegg approved these changes May 3, 2019

Copy link
Member

left a comment

Seems to work!

Though I'm concerned about why .id is no longer available.

@christianbundy christianbundy force-pushed the fix-profile-issue branch from 981ad06 to 54d5340 May 3, 2019

@christianbundy

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Thanks, I'll merge now.

I'm also confused at why that API changed between sbot 12 and 13. Weird. I looked through the source and didn't see any other usage, so I'm hoping there aren't any other breakages.

(btw, force-pushed to remove my dependency change commit)

@christianbundy christianbundy merged commit 3712a11 into master May 3, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.