Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles: revert emoji back to old size before NotoColorEmoji #1139

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
2 participants
@mmckegg
Copy link
Member

commented Jul 2, 2019

This PR makes the emoji appear slightly bigger. I attempted to match the size of emojis before the Noto emoji were added.

Before:

Screen Shot 2019-07-02 at 5 11 28 PM

Screen Shot 2019-07-02 at 5 34 55 PM

After:

Screen Shot 2019-07-02 at 5 12 19 PM

Screen Shot 2019-07-02 at 5 34 00 PM

@mmckegg mmckegg requested a review from christianbundy Jul 2, 2019

@christianbundy

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Sweet! I tried to make emoji bigger in the suggestion box but couldn't figure it out, thanks a lot!

I compared back and forth and I think my personal preference is the default emoji size rather than 120%, but I can barely notice it and I don't feel strongly about it at all. Super happy to merge this, thanks a lot Matt!

@christianbundy christianbundy merged commit ca68a3b into master Jul 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.