New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default background-color for user input elements #372

Merged
merged 4 commits into from May 3, 2016

Conversation

Projects
None yet
3 participants
@ansuz

ansuz commented May 2, 2016

I'll start by saying I'm totally open to doing everything I did in a different way, but this PR has some minor improvements (for those running on a somewhat sketchy platform).

I read through some of the less files, and set these new values where I thought they made sense.

My problem was that gnome's dark theme gives firefox input and textareas a black background, which made user input fields practically unreadable in poor lighting.

I found two seemingly appropriate files for adding style rules for these elements, and set their values to use @color-user-input. This value is defined in a new file I created (colors.less).

My thought was that if we start to put colors into one file, it will be easier in the future for people to reskin their client by tweaking these values. I used 'white' for a background.

Thoughts?

@Kubuxu

This comment has been minimized.

Kubuxu commented May 2, 2016

I am also affected by same problem where using dark GTK style makes input boxes dark inside.

@pfrazee

This comment has been minimized.

Member

pfrazee commented May 2, 2016

I'm 👍 this change, but let's get rid of the colors.less. Variables either need to be used consistently or not at all.

remove colors.less
implement color styles for user input directly in source files
@ansuz

This comment has been minimized.

ansuz commented May 3, 2016

Changes are now implemented directly in the files without colors.less.

I think it would be a nice idea to have colors in one place so people can tweak their installation a little more easily, but I'd much rather have the changes land :) Maybe later?

@pfrazee

This comment has been minimized.

Member

pfrazee commented May 3, 2016

Yeah that's fine, it just needs to be consistent

@pfrazee pfrazee merged commit 2fddd9e into ssbc:master May 3, 2016

@pfrazee

This comment has been minimized.

Member

pfrazee commented May 3, 2016

thanks! 👍

@ansuz

This comment has been minimized.

ansuz commented May 3, 2016

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment