New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation in Portuguese (pt-PT) #637

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@ktorn
Collaborator

ktorn commented Oct 2, 2017

I left the strings for the other languages in their respective language's locale, to make it easier to switch back.

@mmckegg

This comment has been minimized.

Show comment
Hide comment
@mmckegg

mmckegg Oct 2, 2017

Member

Awesome thanks @ktorn!

I left the strings for the other languages in their respective language's locale, to make it easier to switch back.

The language picker shows both your currently selected translation of the name plus the local name so there is no need to worry about this.

screen shot 2017-10-03 at 7 20 11 am

The content in brackets is derived from your own local language (e.g. `"en": "Inglês") would show as "EN - English (Inglês)" when Portuguese was selected.


I added you as a collaborator. Feel free to merge once you are happy!

Member

mmckegg commented Oct 2, 2017

Awesome thanks @ktorn!

I left the strings for the other languages in their respective language's locale, to make it easier to switch back.

The language picker shows both your currently selected translation of the name plus the local name so there is no need to worry about this.

screen shot 2017-10-03 at 7 20 11 am

The content in brackets is derived from your own local language (e.g. `"en": "Inglês") would show as "EN - English (Inglês)" when Portuguese was selected.


I added you as a collaborator. Feel free to merge once you are happy!

@ktorn

This comment has been minimized.

Show comment
Hide comment
@ktorn

ktorn Oct 2, 2017

Collaborator

@mmckegg got it. Amended the commit.
The option to merge is not showing for me though.

Collaborator

ktorn commented Oct 2, 2017

@mmckegg got it. Amended the commit.
The option to merge is not showing for me though.

@ktorn

This comment has been minimized.

Show comment
Hide comment
@ktorn

ktorn Oct 2, 2017

Collaborator

Nvm, didn't notice the invitation in my inbox. Thanks!

Collaborator

ktorn commented Oct 2, 2017

Nvm, didn't notice the invitation in my inbox. Thanks!

@ktorn ktorn merged commit 5bd646e into ssbc:master Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment