New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localising error messages #3

Open
mmckegg opened this Issue Oct 4, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@mmckegg
Member

mmckegg commented Oct 4, 2018

I would like to display the error message (with actual file size etc) in Patchwork, but the way that the error is given doesn't give access to the file size. What about adding an error code to the error node style?

var error = new Error('Some message')
error.code = 'ETOOBIG'
error.fileSize = fileSize
error.fileName = fileName
cb(error)

cc @mixmix

@mixmix

This comment has been minimized.

Show comment
Hide comment
@mixmix

mixmix Oct 5, 2018

Member

yeah I think that's a great idea.
You can open a PR and just merge that if you like!

I'll go add this repo to ssbc org on npm so you can publish too

Member

mixmix commented Oct 5, 2018

yeah I think that's a great idea.
You can open a PR and just merge that if you like!

I'll go add this repo to ssbc org on npm so you can publish too

@mmckegg

This comment has been minimized.

Show comment
Hide comment
@mmckegg

mmckegg Oct 6, 2018

Member

Cool, I'll do this sometime!

Member

mmckegg commented Oct 6, 2018

Cool, I'll do this sometime!

@mmckegg mmckegg self-assigned this Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment