Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Few bugs and errors (1.20.4) #92

Closed
kingkuys2123 opened this issue Dec 31, 2023 · 3 comments · Fixed by #93
Closed

[bug] Few bugs and errors (1.20.4) #92

kingkuys2123 opened this issue Dec 31, 2023 · 3 comments · Fixed by #93
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@kingkuys2123
Copy link
Contributor

kingkuys2123 commented Dec 31, 2023

Mod Version (e.g. Fabric 0.3.4):

Minecraft 1.20.4
Fabric 0.15.3
Fabric API 0.91.3
Java 20.0.2
Scriptor 1.0.4

ISSUES:

  1. Parsing errors loading custom advancements shows up in the logs upon loading a world.

  2. A Warning shows up in the log saying missing textures [20:35:50] [Worker-ResourceReload-3/WARN]: Missing textures in model scriptor:light#: minecraft:textures/atlas/blocks.png:scriptor:entity/empty_circle

  3. Missing break particles for chalk circles, runes and magic light
    2023-12-31_20 55 26

  4. You can place chalk circles on chalk circles (also with runes), unless this is intentional. Additionally chalks stays in the air or float when there is no block below it, the chalk should break if there is no block below it.
    2023-12-31_20 56 58

  5. Apparently, you can place chalk down without looking at the block, I can't explain it so heres a video:

chalk.mp4
@ssblur
Copy link
Owner

ssblur commented Dec 31, 2023

Thank you for reporting these issues! The fourth item is intentional, and the fifth item is a consequence of the vanilla trace function, so while I will look into it I may not be able to resolve it elegantly at the moment.

I will look into the first item and can resolve the second and third items promptly. I'll update this ticket once these are all addressed, though it may be a few days as I'm still busy with the holidays.

If you run into any new issues in the meantime, please feel free to open additional tickets. Thank you again for reporting!

@ssblur ssblur mentioned this issue Dec 31, 2023
@ssblur ssblur self-assigned this Dec 31, 2023
@ssblur ssblur added bug Something isn't working enhancement New feature or request labels Dec 31, 2023
@ssblur
Copy link
Owner

ssblur commented Dec 31, 2023

Hey, found some time to sort this sooner than expected. Working on a few other minor changes before the next minor version, so these fixes will be rolled into that update. Thank you again for reporting, please let me know if you continue to have issues with 1-3 after upgrading to 1.0.5

@kingkuys2123
Copy link
Contributor Author

Sweet, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants