Change binary writer to default 64-bit floats to 32-bit floats #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with other writers
djhoese
added
enhancement
component:writer
|
This will keep failing until pytroll/satpy#1646 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid inconsistencies as Satpy changes, the binary writer needs to have consistent output for floating point data. With current versions of xarray (this may change in the future) it is very easy for Satpy to accidentally upcast 32-bit floats to 64-bit floats. This amount of precision is unnecessary for most remote-sensing satellite instruments and wastes space and processing time. This PR makes it so instead of defaulting to the same data type as the input data, the writer will cast 64-bit floats as 32-bit floats. This way if Satpy or xarray changes in the future produce the same data as 32-bit floats, this won't change output for P2G users.
This PR also includes fixing output filenames for the geotiff and binary writers, fixing the default radiance enhancement configuration, and adding a
--plotoption to the compare script for debugging.