Hyphen in hostname fix #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Apologies for closing and opening a related pull request. I had not put this change in its own branch)
Thank you for creating sshuttle, it's an awesome tool that's been invaluable on numerous occasions!
Earlier today I ran into an issue when I tried to use a hostname with a hyphen in one of its labels (e.g.
my-server.foobar.com) due to the current regexrx = r'([\w\.]+)(?:/(\d+))?(?::(\d+)(?:-(\d+))?)?$'inoptions.pynot accounting for hyphens.The quickest (and simplest) fix which passes the Travis unit tests was to add a hyphen in the list of allowed characters and to update
([\w\.]+)to([\w\.\-]+).