Allow log_dir option to be given to Daemons.run #10

Merged
merged 2 commits into from Mar 7, 2013

Conversation

Projects
None yet
2 participants
@jamoes
Contributor

jamoes commented Aug 4, 2012

Utilizes the :log_dir option of the Daemons gem to allow users to place their pid files in a separate directory than their log files.

For example, you can now launch scheduler_daemon as such:

bundle exec scheduler_daemon start -- --pid_dir=tmp/pids --log_dir=log/

@jamoes

This comment has been minimized.

Show comment Hide comment
@jamoes

jamoes Aug 5, 2012

Contributor

Closing, because upon further testing, it seems this option always causes it to log to /dev/null, so it seems the Daemons gem doesn't properly handle the log_dir option. I'll reopen or recreate if I can figure it out.

Contributor

jamoes commented Aug 5, 2012

Closing, because upon further testing, it seems this option always causes it to log to /dev/null, so it seems the Daemons gem doesn't properly handle the log_dir option. I'll reopen or recreate if I can figure it out.

@jamoes jamoes closed this Aug 5, 2012

@jamoes jamoes reopened this Aug 5, 2012

@jamoes

This comment has been minimized.

Show comment Hide comment
@jamoes

jamoes Aug 5, 2012

Contributor

Reopening: Daemons simply requires the full path name for its arguments, so in order to utilize this, you'd have to run:

bundle exec scheduler_daemon start -- --pid_dir=/full/path/to/project/tmp/pids --log_dir=/full/path/to/project/log/

Contributor

jamoes commented Aug 5, 2012

Reopening: Daemons simply requires the full path name for its arguments, so in order to utilize this, you'd have to run:

bundle exec scheduler_daemon start -- --pid_dir=/full/path/to/project/tmp/pids --log_dir=/full/path/to/project/log/

@jamoes

This comment has been minimized.

Show comment Hide comment
@jamoes

jamoes Jan 17, 2013

Contributor

Any update on getting this included? The change is pretty straightforward.

Contributor

jamoes commented Jan 17, 2013

Any update on getting this included? The change is pretty straightforward.

ssoroka added a commit that referenced this pull request Mar 7, 2013

Merge pull request #10 from jamoes/log_dir
Allow log_dir option to be given to Daemons.run

@ssoroka ssoroka merged commit eafa976 into ssoroka:master Mar 7, 2013

@ssoroka

This comment has been minimized.

Show comment Hide comment
@ssoroka

ssoroka Mar 7, 2013

Owner

Thanks :)

Owner

ssoroka commented Mar 7, 2013

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment