fix: --prompt flag now auto-submits to begin session #4706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sst#4700 - Add submit() method to PromptRef interface to expose internal submit function - Move submit function definition before ref assignment to avoid circular reference - Add auto-submit logic in Home component with 100ms delay after setting prompt - When --prompt is provided, it now both populates input AND auto-submits Changes: - packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx: Add submit() to PromptRef and expose in ref - packages/opencode/src/cli/cmd/tui/routes/home.tsx: Add setTimeout to auto-submit prompt after setting
|
@fifthfrankie Thanks for getting on this so fast. I'm not familiar with the codebase; is it easy to write a regression test for this? If it regressed once, it may regress again later. |
Collaborator
|
it only regressed because the whole tui was rewritten I wouldn't sweat a test may be more work than it's worth Also we don't wanna use setTimeout if we can help it |
github-actions
bot
force-pushed
the
dev
branch
from
f8ee907 to
6a9856d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4700
output: when --prompt is provided, it now both populates input AND auto-submits