Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Credit: Deploy a React App to AWS -- SSL certificate before setting up domain with CloudFront #479

Merged
merged 4 commits into from
May 29, 2020

Conversation

miksimal
Copy link
Contributor

Hi Serverless-Stack folks -- thanks a lot for a really excellent resource!

I was following the extra credit chapter on deploying a React app on AWS and found that I could not set up my domain with CloudFront until I had Set up SSL.

I think it's most likely due to me not having any certificate in the Certificate Manager at the time. Or something having changed on AWS since the subchapter was written.

In addition, I felt that some repetition could be avoided by moving the certificate generation to earlier. For example, instead of first creating the s3 bucket for redirects and then later going back to edit it to use HTTPS, we can now set it to HTTPS from the start.

This PR changes the order so that the certificate is created as part of "Setup your domain with cloudfront" and the right HTTPS settings are chosen the first time around in both "Setup your domain with cloudfront" and in "Set up www domain redirect". As a result, the "Set up SSL" chapter is no longer needed.

Three updated screenshots are included, following the contribution guidelines.

My first PR to an open source project, so may well have missed something obvious and am ofc very open to feedback. Thanks!

@miksimal miksimal changed the title Ssl before domain Extra Credit: Deploy a React App to AWS -- SSL certificate before setting up domain with CloudFront May 24, 2020
@jayair
Copy link
Contributor

jayair commented May 24, 2020

Hi @miksimal, thank you for taking the time to submit the PR! Most of it makes sense.

The only changes I would make would be to tweak the structure of the chapters a bit. The edited Set up Your Domain with CloudFront chapter is quite big. Let's split its subsections up into 3 chapters:

  • Purchase a Domain with Route 53
  • Setup SSL
  • And leave the rest in, Set up Your Domain with CloudFront

I think these subsections might do better as standalone chapters because of the concepts they cover.

What do you think?

@miksimal
Copy link
Contributor Author

Hi @jayair ! I agree the chapter is a bit heavy and I think your suggested structure makes more sense. Will update my PR by end of day tomorrow with those changes :)

@miksimal
Copy link
Contributor Author

Now updated. Maybe I missed it somewhere obvious, but how do I get the URI link for Discourse comments for the specific chapter (for the new chapter, 'Purchase a Domain with Route 53') ?

@jayair
Copy link
Contributor

jayair commented May 29, 2020

Yeah I'll need to create those threads over on the forums and link them. I also made a small tweak Route53 -> Route 53. But otherwise it looks great! Thank you for your contribution!

@jayair jayair merged commit ad15b15 into sst:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants