add .js extension to tempfile (improves Windows compatibility) #12

Merged
merged 1 commit into from Apr 28, 2011

2 participants

@swaits

On Windows7, I was getting the following complaints:

ExecJS::RuntimeError (Microsoft (R) Windows Script Host Version 5.8
Copyright (C) Microsoft Corporation. All rights reserved.
Input Error: There is no file extension in "C:\Users\swaits\AppData\Local\Temp\execjs20110427-6772-1dnexso".

This is easily resolved by adding a ".js" extension to the tempfile. Luckily, Tempfile.open() already supports this by simply passing it an array, instead of a single String.

@josh josh added a commit that referenced this pull request Apr 28, 2011
@josh josh Merged pull request #12 from swaits/master.
add .js extension to tempfile (improves Windows compatibility)
3c78314
@josh josh merged commit 3c78314 into sstephenson:master Apr 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment